feat: add max-header-length for header length check#85
Open
aj3sh wants to merge 1 commit intoopensource-nepal:mainfrom
Open
feat: add max-header-length for header length check#85aj3sh wants to merge 1 commit intoopensource-nepal:mainfrom
aj3sh wants to merge 1 commit intoopensource-nepal:mainfrom
Conversation
sugat009
reviewed
Mar 18, 2026
Contributor
sugat009
left a comment
sugat009
left a comment
There was a problem hiding this comment.
Supply chain security: please keep SHA pins for write-privileged actions. See inline comments.
sugat009
reviewed
Mar 18, 2026
Contributor
sugat009
left a comment
sugat009
left a comment
There was a problem hiding this comment.
Bug: --max-header-length falsy check allows invalid values. See inline comment with reproduction steps.
sugat009
reviewed
Mar 18, 2026
Contributor
sugat009
left a comment
sugat009
left a comment
There was a problem hiding this comment.
Question on the architectural direction for configurable validator options. See inline comment.
sugat009
reviewed
Mar 18, 2026
Contributor
sugat009
left a comment
sugat009
left a comment
There was a problem hiding this comment.
Additional review comments using conventional comments labels.
sugat009
requested changes
Mar 18, 2026
- disable default header length check - update dependency actions version - add release details on contributing file
aj3sh
force-pushed
the
max-header-length
branch
from
be9b5b3 to
7844137
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #67
Type of Change
Please mark the appropriate option below to describe the type of change your pull request introduces:
Checklist
Examples:
"fix: Fixed foobar bug","feat(accounts): Added foobar feature".README.md.Additional Notes
[Add any additional notes or context that you think the reviewers should know about.]
By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.